Changeset 24 for include/fflas-ffpack/ffpack_ludivine.inl

Timestamp:

06/19/07 10:08:48 (2 years ago)

Author:

pernet

Message:

* modular-balanced.h : fix a bug in init (double)

* ffpack_ludivine.inl : fix a big in the computation of Q, with Diag = FflasUnit?

* ffpack.h : debugged Echelon and RedEchelon?

Files:

• include/fflas-ffpack/ffpack_ludivine.inl (modified) (2 diffs)

include/fflas-ffpack/ffpack_ludivine.inl

@@ -499 +499 @@
                 if (R < Nup){
                         // Permutation of the 0 rows
-                        for ( size_t i = Nup, j = R ; i < Nup + R2; ++i, ++j){
-                                fcopy( F, N - j, A + j*(lda + 1), 1, A + i*lda + j, 1);
-                                for (typename Field::Element *Ai = A + i*lda + j;
-                                     Ai != A + i*lda + N; ++Ai)
-                                        F.assign (*Ai, zero);
-                                size_t t = Q[j];
-                                Q[j]=Q[i];
-                                Q[i] = t;
+                        if (Diag == FflasNonUnit){
+                                for ( size_t i = Nup, j = R ; i < Nup + R2; ++i, ++j){
+                                        fcopy( F, N - j, A + j*(lda + 1), 1, A + i*lda + j, 1);
+                                        for (typename Field::Element *Ai = A + i*lda + j;
+                                             Ai != A + i*lda + N; ++Ai)
+                                                F.assign (*Ai, zero);
+                                        size_t t = Q[j];
+                                        Q[j]=Q[i];
+                                        Q[i] = t;
+                                }
+                        } else {
+                                for ( size_t i = Nup, j = R+1 ; i < Nup + R2; ++i, ++j){
+                                        fcopy( F, N - j, A + (j-1)*lda + j, 1, A + i*lda + j, 1);
+                                        for (typename Field::Element *Ai = A + i*lda + j;
+                                             Ai != A + i*lda + N; ++Ai)
+                                                F.assign (*Ai, zero);
+                                        size_t t = Q[j-1];
+                                        Q[j-1]=Q[i];
+                                        Q[i] = t;
+                                }
                         }
                 }
@@ -524 +536 @@
 //---------------------------------------------------------------------
 
-template <class Field>
+        template <class Field>
 size_t
 FFPACK::LUdivine_construct( const Field& F, const FFLAS_DIAG Diag,